From c79bb1d11fe396710d2e4e8ada8dc3ca7a2efa44 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maxime=20R=C3=A9aux?= <maxime.reaux@advans-group.com>
Date: Thu, 22 Jan 2026 23:57:01 +0100
Subject: [PATCH] hide players ID

---
 src/warchron/view/ui/ui_main_window.py |  8 ++------
 src/warchron/view/ui/ui_main_window.ui |  7 +------
 src/warchron/view/view.py              | 13 ++++---------
 3 files changed, 7 insertions(+), 21 deletions(-)

diff --git a/src/warchron/view/ui/ui_main_window.py b/src/warchron/view/ui/ui_main_window.py
index a6c422d..795adc1 100644
--- a/src/warchron/view/ui/ui_main_window.py
+++ b/src/warchron/view/ui/ui_main_window.py
@@ -26,12 +26,10 @@ class Ui_MainWindow(object):
         self.playersTable = QtWidgets.QTableWidget(parent=self.playersTab)
         self.playersTable.setGeometry(QtCore.QRect(10, 60, 741, 431))
         self.playersTable.setObjectName("playersTable")
-        self.playersTable.setColumnCount(2)
+        self.playersTable.setColumnCount(1)
         self.playersTable.setRowCount(0)
         item = QtWidgets.QTableWidgetItem()
         self.playersTable.setHorizontalHeaderItem(0, item)
-        item = QtWidgets.QTableWidgetItem()
-        self.playersTable.setHorizontalHeaderItem(1, item)
         self.addPlayerBtn = QtWidgets.QPushButton(parent=self.playersTab)
         self.addPlayerBtn.setGeometry(QtCore.QRect(20, 20, 75, 23))
         self.addPlayerBtn.setObjectName("addPlayerBtn")
@@ -134,7 +132,7 @@ class Ui_MainWindow(object):
         self.menubar.addAction(self.menuHelp.menuAction())
 
         self.retranslateUi(MainWindow)
-        self.tabWidget.setCurrentIndex(1)
+        self.tabWidget.setCurrentIndex(0)
         QtCore.QMetaObject.connectSlotsByName(MainWindow)
 
     def retranslateUi(self, MainWindow):
@@ -142,8 +140,6 @@ class Ui_MainWindow(object):
         MainWindow.setWindowTitle(_translate("MainWindow", "WarChron"))
         item = self.playersTable.horizontalHeaderItem(0)
         item.setText(_translate("MainWindow", "Name"))
-        item = self.playersTable.horizontalHeaderItem(1)
-        item.setText(_translate("MainWindow", "ID"))
         self.addPlayerBtn.setText(_translate("MainWindow", "Add player"))
         self.tabWidget.setTabText(self.tabWidget.indexOf(self.playersTab), _translate("MainWindow", "Players"))
         self.addWarBtn.setText(_translate("MainWindow", "Add war"))
diff --git a/src/warchron/view/ui/ui_main_window.ui b/src/warchron/view/ui/ui_main_window.ui
index c20c876..e7ac7ae 100644
--- a/src/warchron/view/ui/ui_main_window.ui
+++ b/src/warchron/view/ui/ui_main_window.ui
@@ -28,7 +28,7 @@
      </rect>
     </property>
     <property name="currentIndex">
-     <number>1</number>
+     <number>0</number>
     </property>
     <widget class="QWidget" name="playersTab">
      <attribute name="icon">
@@ -52,11 +52,6 @@
         <string>Name</string>
        </property>
       </column>
-      <column>
-       <property name="text">
-        <string>ID</string>
-       </property>
-      </column>
      </widget>
      <widget class="QPushButton" name="addPlayerBtn">
       <property name="geometry">
diff --git a/src/warchron/view/view.py b/src/warchron/view/view.py
index c7942f6..3792855 100644
--- a/src/warchron/view/view.py
+++ b/src/warchron/view/view.py
@@ -47,9 +47,7 @@ class View(QtWidgets.QMainWindow, Ui_MainWindow):
         item = self.playersTable.itemAt(pos)
         if not item:
             return
-        row = item.row()
-        player_item = self.playersTable.item(row, 0)
-        player_id = player_item.data(Qt.ItemDataRole.UserRole)
+        player_id = item.data(Qt.ItemDataRole.UserRole)
         menu = QMenu(self)
         edit_action = menu.addAction("Edit")
         delete_action = menu.addAction("Delete")
@@ -116,12 +114,9 @@ class View(QtWidgets.QMainWindow, Ui_MainWindow):
         table = self.playersTable
         table.setRowCount(len(players))
         for row, player in enumerate(players):
-            name_item = QtWidgets.QTableWidgetItem(player.name)
-            name_item.setData(Qt.ItemDataRole.UserRole, player.id)
-            table.setItem(row, 0, name_item)
-            id_item = QtWidgets.QTableWidgetItem(player.id)
-            id_item.setFlags(id_item.flags() & ~Qt.ItemFlag.ItemIsEditable)
-            table.setItem(row, 1, id_item)
+            play_item = QtWidgets.QTableWidgetItem(player.name)
+            play_item.setData(Qt.ItemDataRole.UserRole, player.id)
+            table.setItem(row, 0, play_item)
         table.resizeColumnsToContents()
 
     def display_wars(self, wars: list):